Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prover): add GPU feature for compressor #1838

Merged
merged 41 commits into from
May 21, 2024
Merged

Conversation

Artemka374
Copy link
Contributor

@Artemka374 Artemka374 commented Apr 30, 2024

What ❔

Integrate GPU proof compressors into monorepo.
GPU compressors can be run with gpu feature.

Why ❔

Running compressors with GPU significantly improves efficiency.
CPU compressor average proving time - 15 minutes
GPU compressor average proving time - 2 minutes

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Left a few questions as I try to understand the changes.

prover/proof_fri_compressor/src/compressor.rs Show resolved Hide resolved
prover/proof_fri_compressor/src/compressor.rs Show resolved Hide resolved
prover/prover_fri/README.md Show resolved Hide resolved
prover/prover_fri/README.md Outdated Show resolved Hide resolved
prover/prover_fri/README.md Show resolved Hide resolved
@Artemka374 Artemka374 requested review from slowli and popzxc May 20, 2024 14:25
checks-config/era.dic Outdated Show resolved Hide resolved
docker/proof-fri-compressor/Dockerfile Outdated Show resolved Hide resolved
docker/proof-gpu-fri-compressor/Dockerfile Outdated Show resolved Hide resolved
docker/proof-gpu-fri-compressor/Dockerfile Outdated Show resolved Hide resolved
prover/setup.sh Outdated Show resolved Hide resolved
perekopskiy
perekopskiy previously approved these changes May 21, 2024
@alexandrst88 alexandrst88 added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit e9a2213 May 21, 2024
52 checks passed
@alexandrst88 alexandrst88 deleted the afo/gpu-compressors branch May 21, 2024 15:31
github-merge-queue bot pushed a commit that referenced this pull request May 21, 2024
🤖 I have created a release *beep* *boop*
---


##
[24.4.0](core-v24.3.0...core-v24.4.0)
(2024-05-21)


### Features

* **prover:** add GPU feature for compressor
([#1838](#1838))
([e9a2213](e9a2213))
* **pruning:** remove manual vaccum; add migration configuring
autovacuum
([#1983](#1983))
([3d98072](3d98072))
* **tests:** Move all env calls to one place in ts-tests
([#1968](#1968))
([3300047](3300047))


### Bug Fixes

* Disallow non null updates for transactions
([#1951](#1951))
([a603ac8](a603ac8))
* **en:** Minor node fixes
([#1978](#1978))
([74144e8](74144e8))
* **en:** run `MainNodeFeeParamsFetcher` in API component
([#1988](#1988))
([b62677e](b62677e))
* **merkle-tree:** Fix tree API health check status
([#1973](#1973))
([6235561](6235561))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[14.3.0](prover-v14.2.0...prover-v14.3.0)
(2024-05-23)


### Features

* **config:** remove zksync home
([#2022](#2022))
([d08fe81](d08fe81))
* **prover_cli:** add general status for batch command
([#1953](#1953))
([7b0df3b](7b0df3b))
* **prover:** add GPU feature for compressor
([#1838](#1838))
([e9a2213](e9a2213))


### Bug Fixes

* **prover:** Fix path to vk_setup_data_generator_server_fri
([#2025](#2025))
([dbe4d6f](dbe4d6f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants