Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Custom DA with SyncLayer #2295

Merged
merged 23 commits into from
Jun 25, 2024

Conversation

StanislavBreadless
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@StanislavBreadless StanislavBreadless changed the title Custom DA with SyncLayer feat!: Custom DA with SyncLayer Jun 21, 2024
@mm-zk mm-zk self-requested a review June 24, 2024 05:17
Copy link
Contributor

Detected VM performance changes

Benchmark name change in estimated runtime change in number of opcodes executed
access_memory N/A +137 (+0.0%)
decode_shl_sub N/A +137 (+0.0%)
call_far N/A +19 (+0.0%)
deploy_simple_contract N/A +11 (+0.1%)
write_and_decode N/A +147 (+0.0%)
finish_eventful_frames N/A +31 (+0.0%)
event_spam N/A +78 (+0.0%)
slot_hash_collision N/A +147 (+0.0%)

Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it run out of gas at a different time. Or that it is behaving completely differently.

@StanislavBreadless StanislavBreadless merged commit 8b8d427 into sync-layer-stable Jun 25, 2024
39 checks passed
@StanislavBreadless StanislavBreadless deleted the sb-custom-da-with-sl branch June 25, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant