fix: bump zksolc from yanked version to 1.3.16 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
a team,
RomanBrodetski,
perekopskiy,
Deniallugo and
popzxc
as code owners
austinabell
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere and
otani88
hatemosphere
approved these changes
Oct 30, 2023
popzxc
approved these changes
Oct 30, 2023
hatemosphere
pushed a commit
that referenced
this pull request
Oct 30, 2023
# What ❔ Bumps the zksolc version to 1.3.16 because 1.3.15 was being used. Assuming this is a more involved process than just bumping this, but figured I'd PR in anyway in case it helped speed anything up. Also, couldn't quickly figure out how to test `docker/contract-verifier/Dockerfile` as it's broken for me for unrelated parts. Also fixes a typo in the init docs, I can separate it if wanted. ## Why ❔ Broken on a fresh install because of yanked version matter-labs/zksolc-bin@2a29ad1 ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
🤖 I have created a release *beep* *boop* --- ## [17.1.0](core-v16.2.0...core-v17.1.0) (2023-11-03) ### ⚠ BREAKING CHANGES * Update to protocol version 17 ([#384](#384)) ### Features * **en:** Cache blocks in `fetch_l2_block` ([#403](#403)) ([b94c845](b94c845)) * Port boojum eth-sender changes ([#293](#293)) ([8027326](8027326)) * **state-keeper:** Disable some seal criteria for boojum ([#390](#390)) ([2343532](2343532)) * Update to protocol version 17 ([#384](#384)) ([ba271a5](ba271a5)) * **vm:** Make calculation for pubdata a bit more percise ([#392](#392)) ([6d0e61c](6d0e61c)) ### Bug Fixes * bump zksolc from yanked version to 1.3.16 ([#348](#348)) ([c32b88f](c32b88f)) * **db-index:** Add missing index from FRI prover jobs ([#334](#334)) ([730447f](730447f)) * **db-query:** use join instead of nested query for FRI prover extracting ([#364](#364)) ([f9cc831](f9cc831)) * **db-query:** use nested query for requeuing FRI prover jobs ([#399](#399)) ([3890542](3890542)) * incorrect directory of intrinsic.rs generated. ([#332](#332)) ([#336](#336)) ([eefaad0](eefaad0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Bumps the zksolc version to 1.3.16 because 1.3.15 was being used. Assuming this is a more involved process than just bumping this, but figured I'd PR in anyway in case it helped speed anything up. Also, couldn't quickly figure out how to test
docker/contract-verifier/Dockerfileas it's broken for me for unrelated parts.Also fixes a typo in the init docs, I can separate it if wanted.
Why ❔
Broken on a fresh install because of yanked version matter-labs/zksolc-bin@2a29ad1
Checklist
zk fmtandzk lint.