feat: Remove generic bounds on L1GasPriceProvider #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montekki
approved these changes
Jan 2, 2024
Deniallugo
approved these changes
Jan 2, 2024
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 2, 2024
🤖 I have created a release *beep* *boop* --- ## [18.13.0](core-v18.12.0...core-v18.13.0) (2024-01-02) ### Features * **contract-verifier:** add zksolc v1.3.19 ([#797](#797)) ([2635570](2635570)) * Remove generic bounds on L1GasPriceProvider ([#792](#792)) ([edf071d](edf071d)) * Remove TPS limiter from TX Sender ([#793](#793)) ([d0e9296](d0e9296)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
…ender (#799) ## What ❔ Follow-up to #792 ## Why ❔ Same reasons ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `cargo spellcheck --cfg=./spellcheck/era.cfg --code 1`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
G: L1GasPriceProviderwithdyn L1GasPriceProvider.StateKeeperandTxSender(and thus all the API structures) are now generic-free.Why ❔
L1GasPriceProvideris not related to any hot loops where dynamic dispatch would be noticeable, so having it as a generic is kinda meaningless anyways.Checklist
zk fmtandzk lint.cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.