Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misleading documentation (OpenZeppelin audit) #591

Merged
merged 3 commits into from Jun 13, 2023
Merged

Fix misleading documentation (OpenZeppelin audit) #591

merged 3 commits into from Jun 13, 2023

Conversation

vladbochok
Copy link
Member

  • Remove outdated information that EIP-1559 transactions are not supported.
  • Add information about reentrancy by replacing .send/.transfer with .call
  • Clean .transfer/.send section

@vladbochok vladbochok requested a review from a team as a code owner June 13, 2023 11:11
@github-actions
Copy link

github-actions bot commented Jun 13, 2023 •
edited

Visit the preview URL for this PR (updated for commit d8c1b7b):

https://aqwzx-zksync-v2-docs--pr591-vb-fix-misleading-do-6xvjcul8.web.app

(expires Tue, 20 Jun 2023 11:14:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ec4de9998e9e17237caea0ab05986cdbc32c4efb

kailash-manasarovar
kailash-manasarovar approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@kailash-manasarovar kailash-manasarovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kailash-manasarovar kailash-manasarovar merged commit 1e236a4 into main Jun 13, 2023
3 checks passed
@kailash-manasarovar kailash-manasarovar deleted the vb-fix-misleading-documentation branch June 13, 2023 11:55
@github-actions
Copy link

🎉 This PR is included in version 1.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailash-manasarovar kailash-manasarovar kailash-manasarovar approved these changes

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vladbochok @kailash-manasarovar @StanislavBreadless