Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds github action for lint, spell, link, fmt checks and resolves errors accordingly #636

Merged
merged 13 commits into from
Jul 27, 2023

Conversation

dutterbutter
Copy link
Contributor

@dutterbutter dutterbutter commented Jul 13, 2023

What πŸ’»

  • Adds github action flow for checking changes for lint, formatting, spelling, links
  • Address linting, formatting, links, and spelling errors produced from checks

Why βœ‹

  • The docs repo currently has no protection against changes introducing spelling mistakes, broken links etc.

Evidence πŸ“·

  • Running the following commands:
yarn lint:dead
yarn lint:fmt
yarn lint:spell
yarn lint:mdl

Notes πŸ“

  • We should add back the pre-commit husky rules

Closes DEVRL-138

@dutterbutter dutterbutter requested a review from a team as a code owner July 13, 2023 18:20
@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Visit the preview URL for this PR (updated for commit 5b37ca0):

https://aqwzx-zksync-v2-docs--pr636-db-gh-actions-s6o862mr.web.app

(expires Wed, 02 Aug 2023 14:56:41 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

Sign: ec4de9998e9e17237caea0ab05986cdbc32c4efb

@MexicanAce
Copy link
Collaborator

doing_the_lords_work

@dutterbutter dutterbutter requested a review from uF4No July 24, 2023 18:05
@dutterbutter
Copy link
Contributor Author

@uF4No @MexicanAce updated to resolve conflicts.

@dutterbutter
Copy link
Contributor Author

@MexicanAce weird the links you've outlined here work correctly tho?

@MexicanAce
Copy link
Collaborator

@MexicanAce weird the links you've outlined here work correctly tho?

@dutterbutter Yes, looks like things are working via the website. Closed the open conversations and PR LGTM πŸ‘

@dutterbutter dutterbutter merged commit 9e2b079 into main Jul 27, 2023
7 checks passed
@dutterbutter dutterbutter deleted the db/gh-actions branch July 27, 2023 16:51
@github-actions
Copy link

πŸŽ‰ This PR is included in version 1.5.2 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants