fix: disable l2 to l1 events because of eip4844 #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montekki
requested review from
AnastasiiaVashchuk,
Deniallugo and
haraldh
as code owners
montekki
changed the title
montekki
pushed a commit
that referenced
this pull request
Mar 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.6.6](v0.6.5...v0.6.6) (2024-03-04) ### Bug Fixes * disable l2 to l1 events because of eip4844 ([#398](#398)) ([29b6a72](29b6a72)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
|
Hello @montekki, I'm trying to run this project locally but without success. Would you care to explain why you don't listen for L2-L1 events anymore after EIP-4844? |
|
In addition, do you know if a hyperchain that is not EIP-4844 upgraded would have an issue running the latest version of this project? |
4 tasks
montekki
added a commit
that referenced
this pull request
Apr 24, 2024
# What ❔ We are currently no longer track L2ToL1Logs from L1 (removed in #398 ), so no need to try to start from the last seen block for those events ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `cargo fmt`.
|
@therealdannzor we have only listened for these events in the informational purposes, this table was never used in any actian finalization logic. It must not affect your local setup running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.