feat: adds withdrawal finalizing logic. #56
Conversation
|
40851b2 adds initial implementation of finalizer that migrates data from watcher table into 
|
| config.batch_finalization_gas_limit, | ||
| ); | ||
|
|
||
| let finalizer = finalizer::Finalizer::new( |
There was a problem hiding this comment.
Now it became a bit confusing:
We have WithdrawalFinalizer and Finalizer
There was a problem hiding this comment.
Let's choose the proper names for all components
There was a problem hiding this comment.
Yes I wanted to do rename in another patch not to bloat this one
| let is_finalized = self | ||
| .is_withdrawal_finalized(event.tx_hash, index, event.token) | ||
| .await?; | ||
| let is_finalized = false; |
There was a problem hiding this comment.
why is it always false?
There was a problem hiding this comment.
This field is being retied as all relevant info now lives in finalization_data table. Hoever I believe that we cannot delete this field since it would be breaking?
There was a problem hiding this comment.
So, I think in terms of the stage of the project we can.
We can't afford a nonworking state keeper.
But here it's better to have less legacy
There was a problem hiding this comment.
column removed in d667fc3
finalizer/src/lib.rs
Outdated
|
|
||
| // process withdrawals that have been predicted as unsuccessful. | ||
| // | ||
| // there may be two reasons for such predictions: |
There was a problem hiding this comment.
It's just the main reasons.
But it also possible, that ERC20 contract reject those txs for some internal reasons
finalizer/src/lib.rs
Outdated
| where | ||
| M2: ZksyncMiddleware + 'static, | ||
| { | ||
| let migrator_handle = tokio::spawn(params_fetcher_loop(self.pgpool.clone(), middleware)); |
No description provided.