MM-29929 Fix for unread messages toast on marking channel as unread (m…

…attermost#7028) * The initOffset we use for displaying toast should be only used mount as that is not a relative scroll position and is only set on mount * Changing this to show unread toast on all occasions of marking channel as unread other than channel at bottom
mattermost-build · Nov 6, 2020 · 92f5d86 · 92f5d86
1 parent e56a42d
commit 92f5d86
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/components/toast_wrapper/toast_wrapper.jsx b/components/toast_wrapper/toast_wrapper.jsx
@@ -98,15 +98,17 @@ class ToastWrapper extends React.PureComponent {
                 showMessageHistoryToast = props.initScrollOffsetFromBottom > THRESHOLD_FROM_BOTTOM || !props.atLatestPost;
             }
 
-            // show unread toast when a channel is marked as unread
-            if (props.channelMarkedAsUnread && !prevState.channelMarkedAsUnread && !prevState.showUnreadToast) {
-                showUnreadToast = props.initScrollOffsetFromBottom > THRESHOLD_FROM_BOTTOM;
-            }
-
-            // show unread toast when a channel is remarked as unread using the change in lastViewedAt
-            // lastViewedAt changes only if a channel is remarked as unread in channelMarkedAsUnread state
-            if (props.channelMarkedAsUnread && props.lastViewedAt !== prevState.lastViewedAt) {
-                showUnreadToast = props.initScrollOffsetFromBottom > THRESHOLD_FROM_BOTTOM;
+            if (!props.atBottom) {
+                // show unread toast when a channel is marked as unread
+                if (props.channelMarkedAsUnread && !prevState.channelMarkedAsUnread && !prevState.showUnreadToast) {
+                    showUnreadToast = true;
+                }
+
+                // show unread toast when a channel is remarked as unread using the change in lastViewedAt
+                // lastViewedAt changes only if a channel is remarked as unread in channelMarkedAsUnread state
+                if (props.channelMarkedAsUnread && props.lastViewedAt !== prevState.lastViewedAt) {
+                    showUnreadToast = true;
+                }
             }
         }
 

diff --git a/components/toast_wrapper/toast_wrapper.test.jsx b/components/toast_wrapper/toast_wrapper.test.jsx
@@ -145,7 +145,7 @@ describe('components/ToastWrapper', () => {
             const wrapper = shallowWithIntl(<ToastWrapper {...props}/>);
             expect(wrapper.state('showUnreadToast')).toBe(false);
             wrapper.setProps({channelMarkedAsUnread: true, atBottom: false});
-            expect(wrapper.state('showUnreadToast')).toBe(false);
+            expect(wrapper.state('showUnreadToast')).toBe(true);
         });
 
         test('Should have unread toast channel is marked as unread again', () => {
@@ -170,12 +170,12 @@ describe('components/ToastWrapper', () => {
                 ],
             });
 
-            expect(wrapper.state('showUnreadToast')).toBe(false);
+            expect(wrapper.state('showUnreadToast')).toBe(true);
             wrapper.setProps({atBottom: true});
             expect(wrapper.state('showUnreadToast')).toBe(false);
             wrapper.setProps({atBottom: false});
             wrapper.setProps({lastViewedAt: 12342});
-            expect(wrapper.state('showUnreadToast')).toBe(false);
+            expect(wrapper.state('showUnreadToast')).toBe(true);
         });
 
         test('Should have archive toast if channel is not atLatestPost and focusedPostId exists', () => {