Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-47046 Use version of React DOM provided by web app #98

Closed
catalintomai opened this issue Sep 18, 2022 · 1 comment · Fixed by #99
Closed

MM-47046 Use version of React DOM provided by web app #98

catalintomai opened this issue Sep 18, 2022 · 1 comment · Fixed by #99
Assignees
Milestone

Comments

@catalintomai
Copy link

From here:

"For some more context, see here. The short version though is that we updated the web app to React 17, and there's a chance that plugins will have some issues with it because they're compiled with the React 16 version of ReactDOM. I'm submitting PRs to the 3 products, the demo plugin, and the plugin template to have them use the web app's version of React DOM to fix any immediate issues, but we'll want to properly migrate them to React 17 going forward."

Ticket Link
https://mattermost.atlassian.net/browse/MM-47046

Related Pull Requests
mattermost/mattermost-plugin-playbooks#1489
mattermost/focalboard#3861
mattermost-community/mattermost-plugin-todo#190
mattermost/mattermost-plugin-starter-template#169

@hanzei
Copy link
Contributor

hanzei commented Oct 4, 2022

@mickmister Do you plan to work on this one or do we leave it open for someone to pick it up?

@hanzei hanzei linked a pull request Oct 9, 2022 that will close this issue
@hanzei hanzei removed the Triage label Oct 9, 2022
@hanzei hanzei added this to the v0.3.0 milestone Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants