MM-47046/MM-47052 Use version of React DOM provided by web app #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmhealey
added
2: Dev Review
This was referenced Sep 16, 2022
hmhealey
changed the title
catalintomai
approved these changes
Sep 17, 2022
This was referenced Sep 18, 2022
Closed
Closed
Closed
DHaussermann
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Tested and passed
- I have smoke tested the todo plugin with the latest webapp
- The mark as done carsh is resolved.
- No other issues found.
LGTM!
Edit I forgot how to explicitly note that the PR was also successfully tested with webapp running older version of react.
DHaussermann
added
QA Review Done
hanzei
added
4: Reviews Complete
mickmister
pushed a commit
that referenced
this pull request
Oct 28, 2022
mickmister
added a commit
that referenced
this pull request
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some more context, see here. The short version though is that we updated the web app to React 17, and there's a chance that plugins will have some issues with it because they're compiled with the React 16 version of ReactDOM. I'm submitting PRs to the 3 products, the demo plugin, and the plugin template to have them use the web app's version of React DOM to fix any immediate issues, but we'll want to properly migrate them to React 17 going forward.
Ticket Link
https://mattermost.atlassian.net/browse/MM-47046
Related Pull Requests
mattermost/mattermost-plugin-playbooks#1489
mattermost-community/focalboard#3861
mattermost/mattermost-plugin-demo#153
mattermost/mattermost-plugin-starter-template#169