Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default hashtag includes channel name #30

Merged

Conversation

will7200
Copy link
Contributor

@will7200 will7200 commented Apr 18, 2020

Summary

Closes #10
Default hashtag to use the first 15 characters of a channel name prefixed to the date format.

Ticket Link

JIRA: https://mattermost.atlassian.net/browse/MM-22727

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Apr 20, 2020
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would you mind adding an update to the README letting users know what the default will be?

Copy link
Contributor

@attilamolnar attilamolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach taken in this PR leads to incorrect results, explaination and examples in #10 (comment).

server/meeting.go Outdated Show resolved Hide resolved
iomodo
iomodo previously requested changes Apr 22, 2020
Copy link
Contributor

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @will7200 !
Small change request bellow

server/meeting.go Outdated Show resolved Hide resolved
BREAKING CHANGE: Meeting.HashtagFormat's DateTime formatting must be wrapped in double braces for the plugin to generate the correct datetime string.
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @will7200!

Copy link
Contributor

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @will7200! Apologies on the delay on this review. Everything looks good, great tests!

Just wanted to include a request to add the new requirement for date format
to the help text in the settings modal here

Screen Shot 2020-07-20 at 9 45 53 AM

Maybe adding:

Embed a date writing down what January 2, 2006 would look like within double curly braces, i.e. {{Jan02}}

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #30 into master will increase coverage by 11.81%.
The diff coverage is 88.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #30       +/-   ##
===========================================
+ Coverage   16.46%   28.27%   +11.81%     
===========================================
  Files           6        6               
  Lines         328      343       +15     
===========================================
+ Hits           54       97       +43     
+ Misses        262      229       -33     
- Partials       12       17        +5     
Impacted Files Coverage Δ
server/meeting.go 65.30% <88.23%> (+41.77%) ⬆️
server/utils.go 95.12% <0.00%> (+46.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 853bfe1...2302c21. Read the comment docs.

@will7200
Copy link
Contributor Author

@marianunez I was finally able to get around this, thank you for your patience. I added as instructed.

@hanzei hanzei requested a review from marianunez July 31, 2020 11:56
@hanzei hanzei added the Awaiting Submitter Action Blocked on the author label Jul 31, 2020
@hanzei
Copy link
Contributor

hanzei commented Jul 31, 2020

@will7200 Heads up that I merged master into your branch to update it which has broken CI. Could you please take a look?

@will7200
Copy link
Contributor Author

will7200 commented Aug 1, 2020

@hanzei Fixed

@hanzei hanzei removed the Awaiting Submitter Action Blocked on the author label Aug 1, 2020
@hanzei hanzei requested a review from jfrerich August 1, 2020 09:52
@hanzei hanzei requested review from iomodo and removed request for iomodo August 1, 2020 09:52
Copy link
Contributor

@marianunez marianunez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @will7200. LGTM after @jfrerich suggestions and resolving the merge conflicts below.

Co-authored-by: Jason Frerich <jason.frerich@mattermost.com>
@hanzei hanzei added the Awaiting Submitter Action Blocked on the author label Aug 11, 2020
@hanzei
Copy link
Contributor

hanzei commented Aug 13, 2020

@will7200 Could you please resolve the merge conflicts?

@will7200
Copy link
Contributor Author

@hanzei done

@hanzei hanzei requested a review from jfrerich August 14, 2020 10:36
@hanzei hanzei removed the Awaiting Submitter Action Blocked on the author label Aug 14, 2020
@hanzei
Copy link
Contributor

hanzei commented Aug 14, 2020

Thanks @will7200 👍

@hanzei
Copy link
Contributor

hanzei commented Aug 14, 2020

@jfrerich Could you give this PR a final review?

Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again, @will7200!

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Aug 14, 2020
@hanzei
Copy link
Contributor

hanzei commented Aug 14, 2020

@marianunez @DHaussermann Should this PR get QA reviewed or can we merge it as it is?

@marianunez
Copy link
Contributor

Should this PR get QA reviewed or can we merge it as it is?

If we do skip the QA review here, I would suggest a quick smoke test to the release before deploying to community.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Aug 15, 2020
@hanzei hanzei dismissed iomodo’s stale review August 15, 2020 05:25

Conversation resolved

@hanzei hanzei merged commit 0f165d1 into mattermost-community:master Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Hashtag Format to Channel Name
6 participants