Sync with starter template

[mickmister]

Fixes #52

[jfrerich]

Nice! Now that we are using the new sync tool, I wonder if we should start a channel for discussion on improvements. (We could use a starter-template channel because that doesn't exist either)

Some options I'd like to discuss and propose

• keeping local plan.yml files up to date with the starter-template plan.yml
  • need a way to add or inform local repo plan.yml is out of date and should also be updated
• look in local repo for plan.yml instead of required it to be specified in CLI
• manage changes that occur in files like package.json
  • We should be able to run the sync at any point in time and have it return clean.
  • Perhaps a sync and run step. Which would sync and prune the package.json with npm (post syncing)
• option to not specify the repo directory and have sync clone a clean copy
• sync-all option which would run on all repos (list kept in starter-template file or config file)

[marianunez]

Thanks @mickmister!

[hanzei]

Thanks for the cleanup 👍

I would love to come up with a universal plan.yml that we can just C&P to every repo.

[hanzei]

Is this file really needed?

[mickmister]

Please see my answer here mattermost/mattermost-plugin-github#345 (comment)

[hanzei]

As mentioned in https://github.com/mattermost/mattermost-plugin-github/pull/345/files#r467367661, I don't think this is necessary as go will handle the file itself.

[hanzei]

The list of files here and in https://github.com/mattermost/mattermost-plugin-github/pull/345/files#diff-59ad1e74c7021d75cda8d84e151c24c4 differ. Why is there a diff? Should they be the same?

[hanzei]

Nit pick: It would help with comparing the list of the items are ordered.

[hanzei]

While I would like to see the latest changes from mattermost/mattermost-plugin-starter-template#86 getting merged in this, the PR is already a great improvement in terms of tooling.

Heads up that there are merge conflicts to resolve.

[codecov]

Codecov Report

Merging #53 into master will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   26.04%   26.28%   +0.23%     
==========================================
  Files           6        7       +1     
  Lines         311      312       +1     
==========================================
+ Hits           81       82       +1     
  Misses        213      213              
  Partials       17       17              

Impacted Files	Coverage Δ
server/manifest.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd0e9dd...561e542. Read the comment docs.

[hanzei]

@DHaussermann These are only tooling updates. Maybe they can be tested in release testing of v0.2.1.

[DHaussermann]

Agreed @hanzei please merge.

LGTM!