-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies #55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 26.23% 28.27% +2.04%
==========================================
Files 6 6
Lines 343 343
==========================================
+ Hits 90 97 +7
+ Misses 235 229 -6
+ Partials 18 17 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the diff so huge? If there are only two alerts to fix, why do all of these dependencies get updated?
@hanzei, After running After running It looks like If we prefer only to fix the two dependabot notifications, I can rerun the following and reduce the total number of dependency updates:
|
I'm 1/5 to only fix the ones that If there is an easy way to fix only these two, I would prefer it, but if there is none, I'm fine with using |
This reverts commit 30fab4b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
It might be fine to skip QA review here, as release testing is coming up soon after. |
agree! Merging! |
Summary
In prep for the
v0.1.0
release, we should fix these dependabot alerts.Ticket Link
n/a