Fix panic if channel is meeting is not found #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 26.04% 25.87% -0.17%
==========================================
Files 6 6
Lines 311 313 +2
==========================================
Hits 81 81
- Misses 213 215 +2
Partials 17 17
Continue to review full report at Codecov.
|
jfrerich
approved these changes
Sep 22, 2020
|
@hanzei any thoughts on testing this? Would I need a way to simulate such an error? |
|
@DHaussermann Not really. I don't know what causes the crash, which is why I added the log statement. |
|
@DHaussermann Would you be fine skipping QA review? |
|
@hanzei, makes sense to me. As it is there is no functional testing I can do. |
DHaussermann
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a
panicif the meeting for autocomplete and add a log message.Ticket Link
https://community-daily.mattermost.com/core/pl/g5c8dwh5ufrtpprtontzeecnuc