Place command response in same thread #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
2: Dev Review
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 26.11% 26.03% -0.09%
==========================================
Files 7 7
Lines 314 315 +1
==========================================
Hits 82 82
- Misses 215 216 +1
Partials 17 17
Continue to review full report at Codecov.
|
marianunez
approved these changes
Sep 24, 2020
jfrerich
approved these changes
Sep 25, 2020
|
Given that the fix is straight forward and I've tested it myself, I'm going to merge this PR without QA review. |
hanzei
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Yet another instance of this bug 😕
Ticket Link
Fixes #62