Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #13

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Fix CI #13

merged 2 commits into from
Dec 18, 2019

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Dec 16, 2019

Summary

Update dependencies to fix CI failure

Ticket Link

Fixes #12

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Dec 16, 2019
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Dec 17, 2019
@DHaussermann
Copy link

@hanzei or @crspeller, can you provide some testing guidance on this? I don't this building this locally validates this change.
Should we merge this to master and see if CI deployments work to the Ci-Extensions server are working?

@cpoile
Copy link

cpoile commented Dec 18, 2019

Yep, doing that.

@cpoile cpoile merged commit cdde54e into master Dec 18, 2019
@cpoile cpoile deleted the fix_build branch December 18, 2019 15:37
@DHaussermann DHaussermann removed the 3: QA Review Requires review by a QA tester label Dec 18, 2019
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants