Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with opening and closing brackets #24

Closed
derschatta opened this issue Sep 7, 2018 · 3 comments
Closed

Problem with opening and closing brackets #24

derschatta opened this issue Sep 7, 2018 · 3 comments

Comments

@derschatta
Copy link

This is related to #17 which fixes a bug where text was not autolinked if there was a following punctuation mark.

The same bug occurs if brackets are used. Like in there is a bug (see EXA-1234).
lumbric added a commit to lumbric/mattermost-plugin-autolink that referenced this issue Sep 7, 2018
@lumbric
Fix regex to allow brackets, fixes mattermost-community#24
256fa08
@lumbric
Copy link
Contributor

lumbric commented Sep 7, 2018

Hmm the case there are bugs (EXA-1234) and more things is a bit more diifficult to be fixed. Simply adding the ( to the regex breaks the tests.

@lumbric
Copy link
Contributor

lumbric commented Sep 10, 2018

Hm I should have added the brackets in the first version of the pull request in #23, sorry... It's still not perfect, but I think #25 is another improvement. @coreyhulen, could you have another quick look at #25?

coreyhulen added a commit that referenced this issue Sep 10, 2018
@coreyhulen
Merge pull request #25 from lumbric/patch-2
5a6afd9 
 Fix regex to allow brackets, fixes #24
@coreyhulen
Copy link
Contributor

Looks good.

@lumbric lumbric mentioned this issue Oct 18, 2018
Merged
@ThiefMaster ThiefMaster mentioned this issue Jan 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lumbric @coreyhulen @derschatta