Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable slash command by default #139

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Enable slash command by default #139

merged 1 commit into from
Dec 2, 2020

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Oct 22, 2020

Summary

Given that in Cloud the slash command are the only way to configure the plugin, we should enabled it by default. The feature has soaked for long enough.

Ticket Link

Fixes #137

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 22, 2020
@hanzei hanzei added this to the v1.3.0 milestone Oct 22, 2020
@hanzei hanzei requested review from levb and jfrerich October 22, 2020 11:42
@levb levb added the 1: PM Review Requires review by a product manager label Oct 22, 2020
aaronrothschild
aaronrothschild approved these changes Oct 22, 2020
View reviewed changes
Copy link

@aaronrothschild aaronrothschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label Oct 22, 2020
@jfrerich jfrerich removed the 2: Dev Review Requires review by a core committer label Oct 26, 2020
DHaussermann
DHaussermann approved these changes Dec 2, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed.

  • Tested Fresh install on multiple servers
  • When enable radio is True, slash command radio defaults to true as well.
  • No issues enabling or disabling

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Dec 2, 2020
@hanzei hanzei merged commit 874fae3 into master Dec 2, 2020
@hanzei hanzei deleted the 137_enable-slash-commands branch December 2, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronrothschild aaronrothschild aaronrothschild approved these changes

@levb levb levb approved these changes

@jfrerich jfrerich jfrerich approved these changes

@DHaussermann DHaussermann DHaussermann approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Enable slash commands by default
5 participants
@hanzei @aaronrothschild @levb @jfrerich @DHaussermann