Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.3.0 #149

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Release v1.3.0 #149

merged 4 commits into from
Jul 18, 2022

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Feb 8, 2021

Summary

The big diff comes from the indentation changes.

Ticket Link

Part of #144

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Feb 8, 2021
@hanzei hanzei added this to the v1.3.0 milestone Feb 8, 2021
@hanzei hanzei requested a review from levb as a code owner February 8, 2021 11:52
@codecov-io
Copy link

codecov-io commented Feb 8, 2021

Codecov Report

Merging #149 (4353ed5) into master (75c6019) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   40.03%   40.03%           
=======================================
  Files           6        6           
  Lines         602      602           
=======================================
  Hits          241      241           
  Misses        345      345           
  Partials       16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c6019...4353ed5. Read the comment docs.

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Feb 8, 2021
@DHaussermann
Copy link

@hanzei I have done the release testing on v1.3.0
I don't see the icon in the marketplace as per this PR #148
When I look in the asset folder I do see the new .svg but it does not show on the marketplace after the plugin has been uploaded and enabled.

Version bump, Default enable slash command and autocomplete all new to 1.3 are all working as expected so I have the correct build deployed. Any thoughts?

@hanzei
Copy link
Contributor Author

hanzei commented Aug 12, 2021

@DHaussermann I would like to get #160 into this release. Let's deffer on this PR for some time. I will let you know once it's ready for review.

@hanzei hanzei removed the request for review from DHaussermann August 12, 2021 08:23
@hanzei hanzei added the Work In Progress Not yet ready for review label Aug 12, 2021
@hanzei hanzei removed the 3: QA Review Requires review by a QA tester label Oct 28, 2021
@hanzei hanzei added the 3: QA Review Requires review by a QA tester label Mar 16, 2022
@hanzei
Copy link
Contributor Author

hanzei commented Mar 31, 2022

/update-branch

@hanzei hanzei removed the Work In Progress Not yet ready for review label Mar 31, 2022
@hanzei
Copy link
Contributor Author

hanzei commented Mar 31, 2022

@DHaussermann @dipak-demansol This release ist ready for review

@dipak-demansol dipak-demansol self-requested a review March 31, 2022 12:17
@DHaussermann DHaussermann self-requested a review July 15, 2022 20:33
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jul 15, 2022
@DHaussermann
Copy link

@mickmister I've now had time to circle back and close off the release testing for this.

Would it be possible for you to merge this and cut a release?

@mickmister mickmister merged commit 85e789e into master Jul 18, 2022
@mickmister mickmister deleted the release_v1.3.0 branch July 18, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants