Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lint #200

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Fixed lint #200

merged 3 commits into from
Nov 2, 2022

Conversation

levb
Copy link
Contributor

@levb levb commented Nov 1, 2022

Summary

Fixed broken lint

@levb levb added the 2: Dev Review Requires review by a core committer label Nov 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2022

Codecov Report

Base: 40.79% // Head: 40.79% // No change to project coverage 👍

Coverage data is based on head (974c7b4) compared to base (85e789e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   40.79%   40.79%           
=======================================
  Files           6        6           
  Lines         679      679           
=======================================
  Hits          277      277           
  Misses        382      382           
  Partials       20       20           
Impacted Files Coverage Δ
server/autolinkplugin/command.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei
Copy link
Contributor

hanzei commented Nov 1, 2022

@levb Heads up that I updated the golangci config to match https://github.com/mattermost/mattermost-plugin-starter-template/blob/master/.golangci.yml. I hope you don't mind.

Copy link

@javaguirre javaguirre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "typical no-dot at the end" error ;-)

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 2, 2022
@hanzei hanzei merged commit 0f44cfb into master Nov 2, 2022
@hanzei hanzei deleted the lev-fix-lint branch November 2, 2022 11:23
@hanzei hanzei added this to the v1.4.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants