Handling autolink nodes too, not only text nodes

[jespino]

No description provided.

[coreyhulen]

Looks good but can you add a few test cases to https://github.com/mattermost/mattermost-plugin-autolink/blob/master/server/autolinker_test.go ?

[jespino]

Sure

[jespino]

Actually, is not there, must be in the plugin_test.go, because autolink.go only deals with the replacement of text, don't care about markdown or nodes.

[jespino]

Done :)

[jespino]

I added the t.Run in the text to be more "verbose" about which cases are working and which are failing.

[ThiefMaster]

Actually, is not there, must be in the plugin_test.go, because autolink.go only deals with the replacement of text, don't care about markdown or nodes.

What about merging the two sets of test cases, moving them to a single place, and then using same set of test data for both plugin_test and autolink_test?

[jespino]

@ThiefMaster I think it can be done, but I'm not 100% sure about doing it, I like to have the test cases inside the test itself, if I have to import shared testcases elsewhere will look weird. Anyway, if you have an strong opinion here, you can make a PR and we can discuss it seeing how it ends.