Adding attribute by team name #40

nathanaelhoun · 2020-06-15T22:52:21Z

Summary

Add attributes by team membership
Customise settings from UI with a team picker
Update README.md

I didn't tested if it doesn't break the GroupID version, because I don't have access to an E20 server, but I tested the others cases.

Inspired by #15

Ticket Link

No ticket

hanzei · 2020-06-16T07:13:18Z

@aaronrothschild I would like to hear you thoughts on this feature proposal.

marianunez · 2020-06-16T14:22:16Z

@nathanaelhoun Thank you for your contribution! Just to confirm, this new feature will allow custom attributes to be added to all user that belongs to the configured team(s)?

Update README.md (I don't know how to update the second screenshot here)

To update the image, you can either update it directly in Github and upload the image that you would want (you can drag and drop) or you can create a docs folder to add your image and then reference it as a relative path in url markdown added in the Readme - you can see an example of that here

nathanaelhoun · 2020-06-16T16:00:55Z

Thanks for the tip @marianunez !

Yes exactly: every member of the team will have the team attribute. We use it because we don't have the AD groups in our Mattermost instance.

aaronrothschild · 2020-06-16T16:03:51Z

How does this work when you belong to 20+ teams @nathanaelhoun ? Could you post some screenshots here?

nathanaelhoun · 2020-06-16T16:17:04Z

@aaronrothschild This looks like this with one team for each letter in the alphabet. Looks pretty messy I guess.

But it looks normal if a reasonable number of custom attributes are set up (only for two teams and one personal attribute here)

A little clarification: the custom attribute only shows when it's configured for the specified team (it is not automatic for all the teams)

marianunez

@nathanaelhoun overall changes look good. However, I would suggest we rely on saving the teamId in the configuration instead of team name in order for the check to be more robust and to be consistent with how we handle user and groups saved by id.

On the UI side, they could still select by team name if you implement a selector for team like we have there for user_input.

nathanaelhoun · 2020-06-21T20:39:17Z

Thanks for the feeback @marianunez! It took me some time (React is totally new to me, I had to understand a few things), and I force-pushed as I rewrote everything I had changed previously.

Now there is a team selector in the UI, and teams are compared with their ids.

Let me know if it theses changes seems better to you 😄

marianunez · 2020-06-22T16:27:45Z

webapp/src/components/admin_settings/teams_input/teams_input.jsx

+// TeamsInput searches and selects teams displayed by display_name.
+// Teams prop can handle the team object or strings directly if the team object is not available.
+// Returns the selected team ids in the `OnChange` value parameter.
+export default class TeamsInput extends React.Component {


Not in scope with this PR, but it would be interesting to see if we can generalize this input component. Beside formatOptionLabel and getOptionValue, everything else is identical. It would be great if we would pass those as props and it can be reused for both teams and users. It could also possibly solve #28

@nathanaelhoun would you be interested in giving #28 a shot in a separate PR and possibly exploring the approach above that would apply for users, groups and teams?

marianunez

Great work @nathanaelhoun! The team selector looks great! 👍

mickmister

Thanks @nathanaelhoun! I have some requests, mostly regarding style in the javascript side.

webapp/src/components/admin_settings/custom_attribute/custom_attribute.jsx

webapp/src/components/admin_settings/teams_input/teams_input.jsx

nathanaelhoun · 2020-07-02T16:42:05Z

Thanks for the review @mickmister 😄

mickmister

LGTM 👍 One non-blocking request on error string formatting

webapp/src/components/admin_settings/teams_input/teams_input.jsx

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

marianunez · 2020-07-02T18:39:11Z

@aaronrothschild any concerns product-wise with moving forward with this feature?

nathanaelhoun · 2020-07-13T15:50:06Z

Hi! Is there any news on this?

marianunez · 2020-07-13T17:58:50Z

@nathanaelhoun apologies on the delay on this.

@aaronrothschild gentle ping to PM Review so we can go ahead with QA Review.

aaronrothschild

@nathanaelhoun Sorry for the delay, catching up on holiday relatyed backlog. Looks good, I am worried about too many Teams when there is a bunch setup, but that can be conquered later.

Thanks for your contribution!

DHaussermann

Tested and passed

Confirmed members of the team specified are given the custom attributed as expected
Tested adding / removing teams as well as assigning custom attribute to members of multiple teams
Users team membership updated custom attribute as expected
Tested various combination of Team with the existing user grouping.
No issues found
LGTM!

@nathanaelhoun sorry for the delay in testing. Huge thanks for this enhancement!

mickmister · 2020-07-29T18:32:29Z

Looks good, I am worried about too many Teams when there is a bunch setup, but that can be conquered later.

@aaronrothschild Do you think this needs its own ticket?

Thanks so much @nathanaelhoun!

nathanaelhoun requested a review from marianunez as a code owner June 15, 2020 22:52

hanzei requested a review from aaronrothschild June 16, 2020 07:12

hanzei added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 16, 2020

marianunez requested changes Jun 18, 2020

View reviewed changes

Add attributes by team membership

46a5633

Update README.md

651980d

nathanaelhoun requested a review from marianunez June 21, 2020 20:54

marianunez requested a review from mickmister June 22, 2020 16:20

marianunez reviewed Jun 22, 2020

View reviewed changes

marianunez approved these changes Jun 22, 2020

View reviewed changes

mickmister requested changes Jun 29, 2020

View reviewed changes

Adress review request from @mickmister

cbe716d

mickmister approved these changes Jul 2, 2020

View reviewed changes

webapp/src/components/admin_settings/teams_input/teams_input.jsx Outdated Show resolved Hide resolved

Update webapp/src/components/admin_settings/teams_input/teams_input.jsx

31d2922

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

marianunez removed the 2: Dev Review Requires review by a core committer label Jul 2, 2020

mickmister requested a review from DHaussermann July 2, 2020 23:20

aaronrothschild approved these changes Jul 14, 2020

View reviewed changes

marianunez removed the 1: PM Review Requires review by a product manager label Jul 14, 2020

DHaussermann approved these changes Jul 29, 2020

View reviewed changes

DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jul 29, 2020

mickmister merged commit 3c06086 into mattermost-community:master Jul 29, 2020

nathanaelhoun deleted the adding-attribute-by-team branch August 2, 2020 12:17

hanzei added this to the v1.3.0 milestone Aug 7, 2020

larkox mentioned this pull request Aug 27, 2020

Bump version to 1.3.0 #48

Merged

coltoneshaw mentioned this pull request Jul 16, 2021

Increase Mattermost Redux package version #68

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding attribute by team name #40

Adding attribute by team name #40

nathanaelhoun commented Jun 15, 2020 •

edited

Loading

hanzei commented Jun 16, 2020

marianunez commented Jun 16, 2020

nathanaelhoun commented Jun 16, 2020

aaronrothschild commented Jun 16, 2020

nathanaelhoun commented Jun 16, 2020 •

edited

Loading

marianunez left a comment

nathanaelhoun commented Jun 21, 2020 •

edited

Loading

marianunez Jun 22, 2020

marianunez Jul 2, 2020 •

edited

Loading

marianunez left a comment

mickmister left a comment

nathanaelhoun commented Jul 2, 2020

mickmister left a comment

marianunez commented Jul 2, 2020 •

edited

Loading

nathanaelhoun commented Jul 13, 2020

marianunez commented Jul 13, 2020

aaronrothschild left a comment

DHaussermann left a comment

mickmister commented Jul 29, 2020

Adding attribute by team name #40

Adding attribute by team name #40

Conversation

nathanaelhoun commented Jun 15, 2020 • edited Loading

Summary

Ticket Link

hanzei commented Jun 16, 2020

marianunez commented Jun 16, 2020

nathanaelhoun commented Jun 16, 2020

aaronrothschild commented Jun 16, 2020

nathanaelhoun commented Jun 16, 2020 • edited Loading

marianunez left a comment

Choose a reason for hiding this comment

nathanaelhoun commented Jun 21, 2020 • edited Loading

marianunez Jun 22, 2020

Choose a reason for hiding this comment

marianunez Jul 2, 2020 • edited Loading

Choose a reason for hiding this comment

marianunez left a comment

Choose a reason for hiding this comment

mickmister left a comment

Choose a reason for hiding this comment

nathanaelhoun commented Jul 2, 2020

mickmister left a comment

Choose a reason for hiding this comment

marianunez commented Jul 2, 2020 • edited Loading

nathanaelhoun commented Jul 13, 2020

marianunez commented Jul 13, 2020

aaronrothschild left a comment

Choose a reason for hiding this comment

DHaussermann left a comment

Choose a reason for hiding this comment

mickmister commented Jul 29, 2020

nathanaelhoun commented Jun 15, 2020 •

edited

Loading

nathanaelhoun commented Jun 16, 2020 •

edited

Loading

nathanaelhoun commented Jun 21, 2020 •

edited

Loading

marianunez Jul 2, 2020 •

edited

Loading

marianunez commented Jul 2, 2020 •

edited

Loading