Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter errors #81

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Fix linter errors #81

merged 1 commit into from
Nov 3, 2022

Conversation

hanzei
Copy link
Collaborator

@hanzei hanzei commented Nov 3, 2022

Summary

Fix linter errors caused by golangci-lint update.

Ticket Link

None

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Nov 3, 2022
@hanzei hanzei requested a review from larkox as a code owner November 3, 2022 09:44
@larkox
Copy link
Contributor

larkox commented Nov 3, 2022

@hanzei heads up that the ci is failing.

@codecov-commenter
Copy link

Codecov Report

Base: 6.24% // Head: 6.24% // No change to project coverage 👍

Coverage data is based on head (f482bd6) compared to base (9df27f0).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #81   +/-   ##
======================================
  Coverage    6.24%   6.24%           
======================================
  Files          14      14           
  Lines         721     721           
======================================
  Hits           45      45           
  Misses        664     664           
  Partials       12      12           
Impacted Files Coverage Δ
server/plugin.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei hanzei merged commit 6d0bd65 into master Nov 3, 2022
@hanzei hanzei deleted the fix_lint branch November 3, 2022 12:53
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 3, 2022
@hanzei hanzei mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants