Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize with other plugins #15

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Synchronize with other plugins #15

merged 2 commits into from
Jun 8, 2020

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Jun 8, 2020

Summary

Synchronize tooling with other plugins

Ticket Link

None

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 8, 2020
@hanzei hanzei added this to the v0.2.0 milestone Jun 8, 2020
@hanzei hanzei requested review from iomodo and jfrerich June 8, 2020 11:59
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a4b76e8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #15   +/-   ##
=========================================
  Coverage          ?   41.50%           
=========================================
  Files             ?        3           
  Lines             ?       53           
  Branches          ?        0           
=========================================
  Hits              ?       22           
  Misses            ?       28           
  Partials          ?        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b76e8...6d8b4de. Read the comment docs.

Copy link

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one task that could be resolved easily but will need admin privileges on this repo.

# Mattermost Profanity Filter Plugin (Beta)

[![Build Status](https://img.shields.io/circleci/project/github/mattermost/mattermost-plugin-profanity-filter/master.svg)](https://circleci.com/gh/mattermost/mattermost-plugin-profanity-filter)
[![Code Coverage](https://img.shields.io/codecov/c/github/mattermost/mattermost-plugin-profanity-filter/master.svg)](https://codecov.io/gh/mattermost/mattermost-plugin-profanity-filter)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require someone with GH admin privileges to go to

https://codecov.io/gh/mattermost/mattermost-plugin-profanity-filter

  • Settings > General > GitHub Webhook > Create new webhook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levb ☝️

build/custom.mk Outdated Show resolved Hide resolved
Copy link

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Co-authored-by: Jason Frerich <jason.frerich@mattermost.com>
@hanzei hanzei requested a review from jfrerich June 8, 2020 19:01
Copy link

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @hanzei!

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jun 8, 2020
@hanzei hanzei added this to Submitted in Integrations Team Jun 8, 2020
@hanzei hanzei merged commit d152f85 into master Jun 8, 2020
Integrations Team automation moved this from Submitted to Done Jun 8, 2020
@hanzei hanzei deleted the tests branch June 8, 2020 19:03
@jwilander jwilander removed this from Done in Integrations Team Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants