Do not localize dates that appear within code, hyperlinks and quote blocks

[ghost]

Summary

Currently this plugin localizes dates within the full raw message text (that may include Markdown) as sent by a user.

Dates that appear within code blocks should not be localized, since they represent a form of quoted context that should be rendered as-is to recipients. The same is true for blockquotes.

The same is true of hyperlinks, as reported in #49.

To detect and ignore those elements, this change uses the Mattermost-flavoured fork of the marked Markdown processor (as used by mattermost-webapp) to filter them out from the text that is scanned for localizable dates.

Ticket Link

Resolves #25.
Resolves #49.

[mattermod]

Hello @jayaddison-collabora,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[ghost]

It looks like there may be other cases that would make sense to ignore too; blockquote for example. Perhaps it'd make sense to create an array of the renderer properties to override and assign to each of them in a loop.

[ghost]

@mkraft apologies for the repeat notifications; here's another, slightly more involved, merge request.

We deployed a version of mattermost-plugin-walltime at @collabora on 2020-01-05 and I'm yet to hear any reports of complaints / problems with time localization problems since then (that's not to say it hasn't happened, but I'm not yet aware of any problems related to the plugin deployment since then).

The code from that deployment is visible at https://gitlab.collabora.com/tools/mattermost/mattermost-plugin-walltime/-/commits/deploys/test-20220105 -- it includes most of the changes here albeit without the hyperlink and code block filtering.

[ghost]

Please note that the merge commit here (7b11ab0) involved some manual conflict resolution regarding the NPM package-lock.json file.

It wasn't possible to (easily) have the npm command-line tool resolve these automatically, because the version of the CLI tool I ran locally (v8.3.1) complained about an integrity hash change for the marked package dependency.

That's potentially related to some kind of change that NPM made regarding the calculation of integrity checksums. There's a possible note about that here (I'm not really completely clear on the root cause of this, but have seen the same problem occur within other projects as well).

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @aspleenic

[ghost]

cc @mkraft @cpanato (apologies for the notification spam; this is the last of the pull requests I'll mention you on for now) - this is a change to prevent text within preformatted markdown blocks from being transformed by the mattermost-plugin-walltime plugin.

[ghost]

A personal update: I'm planning to resign from @collabora effective Friday 2022-04-01, so this pull request may go unmaintained from that point.