Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-20233] Adding cloud blackbox target discovery microservice. #1

Merged
merged 3 commits into from
Nov 9, 2020
Merged

[MM-20233] Adding cloud blackbox target discovery microservice. #1

merged 3 commits into from
Nov 9, 2020

Conversation

stylianosrigas
Copy link
Contributor

Summary

  • Adding cloud blackbox target discovery microservice.

Ticket Link

https://mattermost.atlassian.net/browse/MM-30233

@cpanato cpanato added the 2: Dev Review Requires review by a core committer label Nov 9, 2020
cpanato
cpanato reviewed Nov 9, 2020
View reviewed changes
main.go Show resolved Hide resolved
cpanato
cpanato reviewed Nov 9, 2020
View reviewed changes
main.go Outdated Show resolved Hide resolved
cpanato
cpanato reviewed Nov 9, 2020
View reviewed changes
main.go Show resolved Hide resolved
cpanato
cpanato reviewed Nov 9, 2020
View reviewed changes
main.go Show resolved Hide resolved
cpanato
cpanato reviewed Nov 9, 2020
View reviewed changes
main.go Show resolved Hide resolved
cpanato
cpanato suggested changes Nov 9, 2020
View reviewed changes
Copy link

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits and comments
thanks for this!

main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
notification.go Show resolved Hide resolved
notification.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Show resolved Hide resolved
@stylianosrigas
Copy link
Contributor Author

some nits and comments
thanks for this!

Thanks for the review @cpanato. All fixed :)

cpanato
cpanato reviewed Nov 9, 2020
View reviewed changes
main.go Show resolved Hide resolved
jwilander
jwilander approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwilander jwilander added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 9, 2020
@stylianosrigas stylianosrigas merged commit af42c58 into main Nov 9, 2020
@jwilander jwilander deleted the MM-30233 branch November 9, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilander jwilander jwilander approved these changes

@cpanato cpanato cpanato approved these changes

@angeloskyratzakos angeloskyratzakos Awaiting requested review from angeloskyratzakos

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stylianosrigas @jwilander @cpanato