GitLab Login broken because of CloudFlare checks

[anebi]

I confirm (by marking "x" in the [ ] below: [x]):

• This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
• This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
• I have read contributing guidelines.

---

Summary

Environment

• Operating System: Mac OS Catalina
• Mattermost Desktop App version:
• Mattermost Server version: Version: 5.28.0

Steps to reproduce

1. Integrate Mattermost login with GitLab
2. Click to login using GitLab on Mattermost Desktop client

Expected behavior
Shows GitLab login page
Observed behavior
CloudFlare browser check happens where redirect never happens

Images

[Willyfrog]

hello and thanks for reporting!

most likely we are blocking some requests that are preventing gitlab to operate. can you try again with the server console opened and see what's going on in the network tab?

[anebi]

Hi,

Thank you very much for your fast reply.

From what I see it fails on GitLab sign_in returning 503.

I am attaching screenshot from network tab and also the export. I hope that this info will be useful.

Regards,
Ali Nebi

devtools-export.har.zip

[amyblais]

@Willyfrog Do the errors above indicate an issue? Is this affecting all Gitlab logins?

[Willyfrog]

no, they don't

I made a couple of quick tests and could reproduce, but I still have to dig into the issue. Most likely something is catching the requests and dropping them.

[Willyfrog]

created a ticket for it: https://mattermost.atlassian.net/browse/MM-31626

[Jenjen1324]

Would also be resolved by implementing OAuth securely: #1451

[Willyfrog]

yes, I agree and that's one of the big changes I'd like to see this year, but implementing OAuth would take some resources that we currently don't have as we are working on some other features. In the meantime, this is a patch to enable users to log into their mattermost instance. I hope that makes sense, but as always feel free to discuss it either here or in the desktop channel in the community server

[Willyfrog]

closing the issue, we are currently in the process to generate an RC with this patch