Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Notifications in notification center do not disappear after they have been read #2878

Closed
6 tasks done
sportfloh opened this issue Oct 10, 2023 · 6 comments
Closed
6 tasks done
Labels

Comments

@sportfloh
Copy link

Before you file a bug report

Mattermost Desktop Version

5.5.0

Operating System

macOS 13 and 14

Mattermost Server Version

9.0.1

Steps to reproduce

Receive a message in MatterMost, read it and still find the notification in the notification center.

Expected behavior

Notifications should disappear after they have been read.

Observed behavior

Every notification stays in the notification center until they are manually dismissed by clicking the "X" on the stack of notifications.

Log Output

[2023-10-05 08:56:05.935] [error] Logger Log level set to: info
[2023-10-05 08:56:06.072] [warn]  [App.Initialize] Current working directory is /, changing into /Applications/Mattermost.app/Contents/MacOS
[2023-10-05 08:56:06.234] [info]  [App.Initialize] Autoupgrade disabled: false
[2023-10-05 08:56:06.365] [info]  [ServerDropdownView] init
[2023-10-05 08:56:06.381] [warn]  [i18nManager] Failed to set new language en-GB
[2023-10-05 08:56:06.382] [warn]  [i18nManager] Failed to set new language DE
[2023-10-05 17:05:17.227] [error] Logger Log level set to: info
[2023-10-05 17:05:17.337] [warn]  [App.Initialize] Current working directory is /, changing into /Applications/Mattermost.app/Contents/MacOS
[2023-10-05 17:05:17.419] [info]  [App.Initialize] Autoupgrade disabled: false
[2023-10-05 17:05:17.461] [info]  [ServerDropdownView] init
[2023-10-05 17:05:17.508] [warn]  [i18nManager] Failed to set new language en-GB
[2023-10-05 17:05:17.509] [warn]  [i18nManager] Failed to set new language DE
[2023-10-05 17:19:44.377] [error] Logger Log level set to: info
[2023-10-05 17:19:44.486] [warn]  [App.Initialize] Current working directory is /, changing into /Applications/Mattermost.app/Contents/MacOS
[2023-10-05 17:19:44.577] [info]  [App.Initialize] Autoupgrade disabled: false
[2023-10-05 17:19:44.623] [info]  [ServerDropdownView] init
[2023-10-05 17:19:44.670] [warn]  [i18nManager] Failed to set new language en-GB
[2023-10-05 17:19:44.670] [warn]  [i18nManager] Failed to set new language DE
[2023-10-06 08:48:10.278] [error] Logger Log level set to: info
[2023-10-06 08:48:10.434] [warn]  [App.Initialize] Current working directory is /, changing into /Applications/Mattermost.app/Contents/MacOS
[2023-10-06 08:48:10.613] [info]  [App.Initialize] Autoupgrade disabled: false
[2023-10-06 08:48:10.712] [info]  [ServerDropdownView] init
[2023-10-06 08:48:10.727] [warn]  [i18nManager] Failed to set new language en-GB
[2023-10-06 08:48:10.728] [warn]  [i18nManager] Failed to set new language DE
[2023-10-08 20:04:07.707] [error] Logger Log level set to: info
[2023-10-08 20:04:07.847] [warn]  [App.Initialize] Current working directory is /, changing into /Applications/Mattermost.app/Contents/MacOS
[2023-10-08 20:04:08.011] [info]  [App.Initialize] Autoupgrade disabled: false
[2023-10-08 20:04:08.155] [info]  [ServerDropdownView] init
[2023-10-08 20:04:08.175] [warn]  [i18nManager] Failed to set new language en-GB
[2023-10-08 20:04:08.176] [warn]  [i18nManager] Failed to set new language DE
[2023-10-08 21:01:49.901] [error] Logger Log level set to: info
[2023-10-08 21:01:49.994] [warn]  [App.Initialize] Current working directory is /, changing into /Applications/Mattermost.app/Contents/MacOS
[2023-10-08 21:01:50.074] [info]  [App.Initialize] Autoupgrade disabled: false
[2023-10-08 21:01:50.120] [info]  [ServerDropdownView] init
[2023-10-08 21:01:50.174] [warn]  [i18nManager] Failed to set new language en-GB
[2023-10-08 21:01:50.175] [warn]  [i18nManager] Failed to set new language DE
[2023-10-08 21:17:50.172] [error] Logger Log level set to: info
[2023-10-08 21:17:50.267] [warn]  [App.Initialize] Current working directory is /, changing into /Applications/Mattermost.app/Contents/MacOS
[2023-10-08 21:17:50.348] [info]  [App.Initialize] Autoupgrade disabled: false
[2023-10-08 21:17:50.391] [info]  [ServerDropdownView] init
[2023-10-08 21:17:50.445] [warn]  [i18nManager] Failed to set new language en-GB
[2023-10-08 21:17:50.446] [warn]  [i18nManager] Failed to set new language DE
[2023-10-09 09:43:35.520] [error] Logger Log level set to: info
[2023-10-09 09:43:35.673] [warn]  [App.Initialize] Current working directory is /, changing into /Applications/Mattermost.app/Contents/MacOS
[2023-10-09 09:43:35.870] [info]  [App.Initialize] Autoupgrade disabled: false
[2023-10-09 09:43:36.008] [info]  [ServerDropdownView] init
[2023-10-09 09:43:36.024] [warn]  [i18nManager] Failed to set new language en-GB
[2023-10-09 09:43:36.024] [warn]  [i18nManager] Failed to set new language DE
[2023-10-10 09:10:02.058] [error] Logger Log level set to: info
[2023-10-10 09:10:02.204] [warn]  [App.Initialize] Current working directory is /, changing into /Applications/Mattermost.app/Contents/MacOS
[2023-10-10 09:10:02.386] [info]  [App.Initialize] Autoupgrade disabled: false
[2023-10-10 09:10:02.522] [info]  [ServerDropdownView] init
[2023-10-10 09:10:02.538] [warn]  [i18nManager] Failed to set new language en-GB
[2023-10-10 09:10:02.538] [warn]  [i18nManager] Failed to set new language DE

Additional Information

I think the same problem has been reported in #1122 but was closed without a fix. Please fix this since it is super annoying. Thanks and cheers!

@devinbinnie
Copy link
Member

@sportfloh As per this comment: #1122 (comment), this is likely an Electron/macOS issue.

I'll have another look as we've done some changes that might affect this, but it's possible that nothing can be done.

@devinbinnie
Copy link
Member

@sportfloh Just wanted to understand the expectations a bit better, do you expect that when you read a message in the channel that the corresponding notification should go away? Or when you open Mattermost should all notifications go away? Or should they only disappear if you click on the notification itself?

@sportfloh
Copy link
Author

@devinbinnie

... do you expect that when you read a message in the channel that the corresponding notification should go away?

Correct, that's the behaviour I'd like to see.

Or when you open Mattermost should all notifications go away?

No.

Or should they only disappear if you click on the notification itself?

A click an a notification should, open MatterMost (if it is not already open), take me to the corresponding message and clear the notification for that message.

Thanks!

@devinbinnie
Copy link
Member

... do you expect that when you read a message in the channel that the corresponding notification should go away?

Correct, that's the behaviour I'd like to see.

Thanks for the feedback, unfortunately this isn't actually something we can do accurately right now. It is possible for a user to interact with a mention on the web app side of things without ever interacting with the notification, and there is currently no mechanism for the web app to tell the Desktop App that the mention has been cleared.

Or should they only disappear if you click on the notification itself?

A click an a notification should, open MatterMost (if it is not already open), take me to the corresponding message and clear the notification for that message.

This however, is something we should be able to do provided that macOS and Electron allow this to work. I'll follow-up on this.

@devinbinnie
Copy link
Member

@sportfloh Looks like the latter issue has been solved in this PR, but unfortunately there's nothing we can do about other notifications at this time.

We'll look into as a future change once we're able to support this. One thing that would need to change would be the Desktop App/Web App API. I'll make a note to look into this.

Closing this bug as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants