-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate options to minify JavaScript on the Desktop Apps #387
Comments
@jnugh Would there be any additional information I could add to the issue? I feel someone who didn't see the discussion in Desktop App might not really understand the full scope of what's talked about here. |
A recap from what was discussed earlier: There are however transpilers that can find (and change) code that might be optimized regarding performance. Adding something like that to the webpack config should be pretty easy I guess. However I have no idea if this would have any measurable impact 😉 |
Anyway, it's good idea to try minification. |
https://github.com/electron-userland/electron-builder/wiki/Options .build.compression is what I mean (I don't know how it compresses the output). |
The option seems to take effects for app whole, e.g. zip. |
yeah thats what I mean - so when you minify js code the compression might not work as good. Both might just zero each other out. But I would say - let's try it out and get some numbers 😄 |
Jira ticket for reference: https://mattermost.atlassian.net/browse/MM-14107 |
JIRA ticket was closing and this wasn't, so closing this as well. |
Jira ticket: https://mattermost.atlassian.net/browse/MM-14107
Currently the desktop app binary doesn't minify JavaScript source code. It also has test code embedded in there too.
This issue is opened to investigate if minification or compression could help reduce binary size and improve performance.
It might also be interesting to see if a JavaScript transpiler can optimize code in a way that would be useful for performance.
The text was updated successfully, but these errors were encountered: