Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update permissions-backend.rst #3285

Merged
merged 3 commits into from Jan 16, 2020
Merged

Update permissions-backend.rst #3285

merged 3 commits into from Jan 16, 2020

Conversation

wiersgallak
Copy link
Contributor

Update of permissions based on the permissions.go file in the server repository: https://github.com/mattermost/mattermost-server/blob/a63684fcb5e3ba7b7522b35c29a4cb27779ba823/model/permission.go

@wiersgallak wiersgallak added 1: PM Review Requires review by a product manager 1: Dev Review Requires review by a core commiter labels Jan 2, 2020
@wiersgallak wiersgallak added the 2: Editor Review Requires review by an editor label Jan 2, 2020
@amyblais amyblais removed the 2: Editor Review Requires review by an editor label Jan 2, 2020
jespino
jespino reviewed Jan 13, 2020
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it is needed, but I miss the join_private_teams permission.

@wiersgallak wiersgallak removed the 1: PM Review Requires review by a product manager label Jan 15, 2020
jespino
jespino approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jespino jespino added 3: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter labels Jan 16, 2020
@jespino jespino merged commit ce8730b into master Jan 16, 2020
@jespino jespino deleted the wiersgallak-patch-17 branch January 16, 2020 11:25
justinegeffen pushed a commit that referenced this pull request Jan 20, 2020
Merge branch 'master' into justine-mmctl
fd3bffe 
* master:
  Fix typo (#3310)
  V5.19 documentation (#3312)
  Update version-archive.rst (#3313)
  Update permissions-backend.rst (#3285)
  Update guest-accounts.rst (#3309)
  Improve breaking change notice in 5.18 changelog regarding module path
justinegeffen pushed a commit that referenced this pull request Jan 20, 2020
Merge branch 'master' into justine-dbrestore
d0c7f4f 
* master:
  Update copyright year to '2015-2020' (#3320)
  Update changelog.md (#3319)
  Fix typo (#3310)
  V5.19 documentation (#3312)
  Update version-archive.rst (#3313)
  Update permissions-backend.rst (#3285)
  Update guest-accounts.rst (#3309)
  Improve breaking change notice in 5.18 changelog regarding module path
@amyblais amyblais removed the 3: Reviews Complete All reviewers have approved the pull request label Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jespino jespino jespino approved these changes

@thefactremains thefactremains thefactremains approved these changes

@amyblais amyblais amyblais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wiersgallak @jespino @thefactremains @amyblais