Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Archived ESLint plugin for Mattermost code. Moved to the monorepo: https://github.com/mattermost/mattermost

License

Notifications You must be signed in to change notification settings

mattermost/eslint-plugin-mattermost

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

10 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

eslint-plugin-mattermost

This package has been replaced by @mattermost/eslint-plugin. It's source code is located here.


An ESLint plugin containing the configuration used by Mattermost as well as support for custom rules specific to the Mattermost code base.

More information on our style guide is available here.

Custom Rules

no-dispatch-getstate

Prevents passing a redux store's getState into its dispatch as an unnecessary second argument.

We started doing this accidentally at some point because of a misunderstanding about how redux-thunk worked, so this stops anyone from making that same mistake again.

Examples of incorrect code for this rule:

export function someAction() {
    return (dispatch, getState) => {
        dispatch(doSomething(), getState);
    };
}

Examples of correct code for this rule:

export function someAction() {
    return (dispatch) => {
        dispatch(doSomething());
    };
}