Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2889 - Hiding images on share modal on personal #2925

Merged
merged 2 commits into from
May 4, 2022

Conversation

asaadmahmood
Copy link
Contributor

@asaadmahmood asaadmahmood commented Apr 26, 2022

Summary

2889 - Hiding images on share modal on personal
Also made some other minor UI updates.

Ticket Link

Fixes #2889
Fixes #2888

@asaadmahmood asaadmahmood requested a review from a team as a code owner April 26, 2022 12:17
@asaadmahmood asaadmahmood requested review from wiggin77 and chenilim and removed request for a team April 26, 2022 12:17
@amyblais amyblais added this to the v0.16 milestone Apr 26, 2022
@amyblais amyblais added 1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer labels Apr 26, 2022
@sbishel sbishel added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Apr 29, 2022
Copy link
Contributor

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wiggin77
Copy link
Contributor

wiggin77 commented May 3, 2022

/update-branch

@sbishel sbishel merged commit fb46097 into mattermost-community:main May 4, 2022
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request May 4, 2022
…#2925)

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
(cherry picked from commit fb46097)
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels May 4, 2022
sbishel pushed a commit that referenced this pull request May 4, 2022
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
(cherry picked from commit fb46097)

Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
Rajat-Dabade pushed a commit to Rajat-Dabade/focalboard that referenced this pull request Jun 21, 2022
…#2925)

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
sbishel added a commit that referenced this pull request Jun 21, 2022
* Feature added: Pressing enter should create a category

* Followed the review request changed and updated the code

* Removed the submit attribute as it no longer been used

* Create .gitpod.yml (#3010)

* update board title when duplicated (#3011)

* Displayed only board members in autocomplete (#2969)

* Displayed only board members in autocomplete

* Removed debug logs

* update min version in Plugin and build (#3018)

* 2889 - Hiding images on share modal on personal (#2925)

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* GH-2469 Add board-bot to team (#3026)

* add bot to team before any mention or subscription notification

* allow duplicating cards/baords if filecopy fails (#3012)

* allow duplicating cards/baords if filecopy fails

* change back to error logs

* standardize env var naming (#3031)

* Translated using Weblate (Malayalam)

Currently translated at 100.0% (303 of 303 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/ml/

* Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/

* Translated using Weblate (German)

Currently translated at 100.0% (312 of 312 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/de/

* implement personal server/desktop cloud advertising

* update for standard colors/button, add telemetry

* only display if active 24 hours

* remove log, update snapshot

* lint fixes

* more lint fixes

* fixes

* add copyright

* Updating UI

* All team users autocomplete new (#3016)

* WIP

* Made search debounced

* Lint fiX

* Fixed tests

* Calledn un-debounced version on first load

* Added delete feature in Table view (#2383)

* Added delete feature in Table view

* Fixed the build failure

* Added test cased for delete the row in table view

* Fixes for useMemo, useCallback and proposed CSS solution

* UI fixes

* Resolved the test-case issue

Co-authored-by: Rajat Dabade <rajat@Rajats-MacBook-Pro.local>

* fix broken jest test

* update singleUser to return workspace UpdateAt as getMe User createAt

* Translated using Weblate (Croatian)

Currently translated at 100.0% (312 of 312 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/hr/

* Translated using Weblate (Persian)

Currently translated at 32.0% (100 of 312 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/fa/

Added translation using Weblate (Persian)

* GH-2959 - Updating boards modal styling (#3048)

* GH-2959 - Updating boards modal styling

* Updating test

* update to version 7.2.0

* Refactor notify init (#3043)

* remove unneeded store interfaces

* - reduce dependencies for notifications service
- notifications service no longer concerned with web socket notifications

gnored, and an empty message aborts the commit.

* use app to add member to board

* remove unneeded API

* remove dependency on app package

* fix webapp jest

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* Adding the board default role for public boards (#2884)

* Adding the default role concept in the backend

* Adding the interface part

* Fix golang-ci lint errors

* Adding local permissions tests

* Address PR review comments

* Improving the code a bit

* Another small fix

* Renaming DefaultRole to MinimumRole

* Setting the minimum role at minimum to check the permissions per roles in the integration tests

* Adding the new minimum role behavior

* Fixing some tests

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* [GH-2442] Improve performance for table column resize (#3032)

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* update template, remove view (#3080)

* update template, remove view

* update new template file

* Translated using Weblate (Turkish)

Currently translated at 100.0% (313 of 313 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/tr/

* Translated using Weblate (Persian)

Currently translated at 31.9% (100 of 313 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/fa/

* Translated using Weblate (Hungarian)

Currently translated at 100.0% (313 of 313 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/hu/

* Translated using Weblate (Chinese (Simplified))

Currently translated at 56.8% (178 of 313 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/zh_Hans/

* Translated using Weblate (Polish)

Currently translated at 100.0% (313 of 313 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/pl/

* Translated using Weblate (English (Australia))

Currently translated at 100.0% (313 of 313 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/en_AU/

* Translated using Weblate (German)

Currently translated at 100.0% (313 of 313 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/de/

* Translated using Weblate (Dutch)

Currently translated at 100.0% (313 of 313 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/nl/

* Translated using Weblate (Chinese (Traditional))

Currently translated at 82.4% (258 of 313 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/zh_Hant/

* Added a Dialog notification after clicking on the Cards hidden button (#3180)

* Added a Dailog notification after clicking on the Cards hidden button

* Reverted the unwanted changes

* Updated required snapshot

* Css fixed

* Snapshot update

* ESlinter fix

* Snapshot update

* Removed HiddenCardCountNotification and used cardLimitNotification template

* Update

Co-authored-by: Mattermod <mattermod@users.noreply.github.com>

* Translated using Weblate (Malayalam)

Currently translated at 100.0% (303 of 303 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/ml/

* Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/

Update translation files

Updated by "Cleanup translation files" hook in Weblate.

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/

* Translated using Weblate (German)

Currently translated at 100.0% (312 of 312 strings)

Translation: Focalboard/webapp
Translate-URL: https://translate.mattermost.com/projects/focalboard/webapp/de/

* Added templates.boardarchive back

* Removed unwanted changes

* Update webapp/i18n/en.json

Co-authored-by: Rajat Dabade <rajat@Rajats-MacBook-Pro.local>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com>
Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
Co-authored-by: Mattermod <mattermod@users.noreply.github.com>
Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
Co-authored-by: Varghese Jose <varghese.jose@tutanota.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: jprusch <rs@schaeferbarthold.de>
Co-authored-by: Milo Ivir <mail@milotype.de>
Co-authored-by: vaheeD khoshnouD <khoshnud@gmail.com>
Co-authored-by: Jesús Espino <jespinog@gmail.com>
Co-authored-by: kamre <eremchenko@gmail.com>
Co-authored-by: Kaya Zeren <kayazeren@gmail.com>
Co-authored-by: Abraham Foam <foam.abraham@gmail.com>
Co-authored-by: Tóth Csaba // Online ERP Hungary Kft <csaba.toth@online-erp.hu>
Co-authored-by: windane <windane@gmail.com>
Co-authored-by: master7 <marcin.karkosz@rajska.info>
Co-authored-by: Matthew Williams <Matthew.Williams@outlook.com.au>
Co-authored-by: JtheBAB <srast@bioc.uzh.ch>
Co-authored-by: Tom De Moor <tom@controlaltdieliet.be>
Co-authored-by: Su Jing Jhong <sujingjhong@gmail.com>
@asaadmahmood asaadmahmood deleted the GH-2889 branch July 28, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: PM Review Requires review by a product manager 2: Dev Review Requires review by a core committer CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
5 participants