Add an endpoint and client method to fetch the boards cloud limits #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbishel
approved these changes
May 12, 2022
sbishel
reviewed
May 12, 2022
| func (a *App) GetBoardsCloudLimits() (*model.BoardsCloudLimits, error) { | ||
| if a.pluginAPI == nil { | ||
| return nil, ErrNilPluginAPI | ||
| } |
There was a problem hiding this comment.
It depends on the UI implementation, but should this just return an unlimited BoardCloudLimits object, so that the UI code works the same.
There was a problem hiding this comment.
0/5 on this, I've updated the response to return a Not Implemented to follow what Channels is doing for unlicensed and non-cloud instances, but I'm happy to return an empty object. Limit = 0 should effectively be the same as no limit, so we can make no distinction and do it like that
mgdelacroix
force-pushed
the
add-limits-endpoint
branch
from
025ce5c
to
186bf14
Compare
|
I'm cherrypicking this to |
harshilsharma63
added a commit
that referenced
this pull request
Jun 6, 2022
…3058) * Add an endpoint and client method to fetch the boards cloud limits * Fix linter * Respond with Not Implemented if the plugin is not set * Fixing server tests * lint fix Co-authored-by: Harshil Sharma <harshilsharma63@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the server dependency to be able to use the new cloud limit plugin APIs and adds an endpoint and a client method to generate and fetch the Boards version of Cloud Limits.
A follow up PR will populate the two fields of the new struct (cardLimitTimestamp and usedCards).