Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-3412] feat: add opengraph tags to website #3413

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SethFalco
Copy link

@SethFalco SethFalco commented Jul 23, 2022

Summary

Adds OpenGraph tags to the website so it looks more attractive when shared in instant messengers or social media.

More information in the GitHub issue.

You're welcome to suggest changing any particular tag that was set, I just chose what I'd think are sensible values. A better image could be used, but thought I'd leave that one up to you rather, I opted to only pick from what static assets are already being served.

This does do a minor change on the side, if the title (tab name) doesn't have Focalboard in it, it appends | Focalboard to it. (Similar to the behavior you have on the Mattermost website.)

For example, the landing page is still:
Focalboard: Open source alternative to Trello, Asana, and Notion

But most other pages went from a format like:
Personal EditionPersonal Edition | Focalboard

Ticket Link

Previews

image

image

@SethFalco SethFalco requested a review from a team as a code owner July 23, 2022 16:10
@SethFalco SethFalco requested review from sbishel and chenilim and removed request for a team July 23, 2022 16:10
@mattermod
Copy link
Contributor

Hello @SethFalco,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@sbishel sbishel added the 1: PM Review Requires review by a product manager label Jul 25, 2022
@sbishel sbishel requested review from wuwinson and removed request for sbishel July 25, 2022 21:59
@chenilim
Copy link
Member

chenilim commented Aug 1, 2022

Thanks @SethFalco! Much appreciated! cc @justinegeffen, @emdecr - I haven't used opengraph tags before, but these LGTM. Please review.

Copy link
Collaborator

@emdecr emdecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition @SethFalco!

@chenilim I'll ask around the team as well to see if they have any suggestions for copy or image changes. Will make another PR with adjustments, if anything. But these changes all look good to me 👍

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@chenilim chenilim removed their request for review October 11, 2022 15:55
@justinegeffen
Copy link
Contributor

The copy looks good to me, thank you!

@justinegeffen
Copy link
Contributor

@wuwinson, can we merge this? :)

@mattermod
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: PM Review Requires review by a product manager Contributor Lifecycle/1:stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Idea: OpenGraph tags
6 participants