-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-3412] feat: add opengraph tags to website #3413
base: main
Are you sure you want to change the base?
Conversation
Hello @SethFalco, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. |
Thanks @SethFalco! Much appreciated! cc @justinegeffen, @emdecr - I haven't used opengraph tags before, but these LGTM. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition @SethFalco!
@chenilim I'll ask around the team as well to see if they have any suggestions for copy or image changes. Will make another PR with adjustments, if anything. But these changes all look good to me 👍
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
The copy looks good to me, thank you! |
@wuwinson, can we merge this? :) |
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Summary
Adds OpenGraph tags to the website so it looks more attractive when shared in instant messengers or social media.
More information in the GitHub issue.
You're welcome to suggest changing any particular tag that was set, I just chose what I'd think are sensible values. A better image could be used, but thought I'd leave that one up to you rather, I opted to only pick from what static assets are already being served.
This does do a minor change on the side, if the
title
(tab name) doesn't haveFocalboard
in it, it appends| Focalboard
to it. (Similar to the behavior you have on the Mattermost website.)For example, the landing page is still:
Focalboard: Open source alternative to Trello, Asana, and Notion
But most other pages went from a format like:
Personal Edition
→Personal Edition | Focalboard
Ticket Link
Previews