Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3916 fix property change #3920

Merged

Conversation

sbishel
Copy link
Collaborator

@sbishel sbishel commented Oct 4, 2022

Summary

Confirm modal is throwing an error, because of object changes.
Uses the intl display for the property type name.

Ticket Link

Fixes #3916

@sbishel sbishel added 2: Dev Review Requires review by a core committer CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 4, 2022
@sbishel sbishel added this to the v7.3 milestone Oct 4, 2022
@sbishel sbishel requested a review from Pinjasaur October 4, 2022 15:35
Copy link
Contributor

@Pinjasaur Pinjasaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, wasn't aware of displayName. LGTM.

@Pinjasaur Pinjasaur merged commit 5bf4039 into mattermost-community:main Oct 4, 2022
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Oct 4, 2022
@mattermod mattermod added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Oct 4, 2022
sbishel added a commit that referenced this pull request Oct 4, 2022
(cherry picked from commit 5bf4039)

Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
@sbishel sbishel deleted the gh-3916-fix-property-change branch October 12, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot change "type" for existing properties when there are values are assigned
3 participants