Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-3947]: Close confirmation dialog box on delete #4031

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

varunKT001
Copy link
Contributor

Summary

Close confirmation dialog box on delete in calendar view.

Ticket Link

Fixes #3947

@mattermod
Copy link
Contributor

Hello @varunKT001,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@varunKT001
Copy link
Contributor Author

@Rajat-Dabade

I fixed the confirmation dialog box for the calendar view. Please review and suggest if any changes are needed.

Thank you.

@Rajat-Dabade Rajat-Dabade self-requested a review October 18, 2022 13:35
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Rajat-Dabade Rajat-Dabade merged commit 4b07ea5 into mattermost:main Oct 18, 2022
@Rajat-Dabade
Copy link
Contributor

@varunKT001, Great work. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Idea: confirmation dialog when deleting a card in calendar/galley view
3 participants