Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates import to read with a scanner #4788

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Updates import to read with a scanner #4788

merged 2 commits into from
Jun 22, 2023

Conversation

mgdelacroix
Copy link
Member

Summary

This PR updates the import reading logic to use a scanner.

Ticket Link

https://mattermost.atlassian.net/browse/MM-53232

@mgdelacroix mgdelacroix added 2: Dev Review Requires review by a core committer 3: Security Review Review requested from Security Team labels Jun 21, 2023
sbishel
sbishel approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, its not worth the extra work to make it configurable, matching channels value seems reasonable to me.

@sbishel sbishel removed the 2: Dev Review Requires review by a core committer label Jun 21, 2023
@mgdelacroix mgdelacroix added 3: Reviews Complete All reviewers have approved the pull request CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed 3: Security Review Review requested from Security Team labels Jun 22, 2023
@mgdelacroix mgdelacroix added this to the v7.11 milestone Jun 22, 2023
@mgdelacroix mgdelacroix merged commit 625526c into main Jun 22, 2023
18 checks passed
@mgdelacroix mgdelacroix deleted the limit-import-size branch June 22, 2023 09:31
@mgdelacroix
Copy link
Member Author

/cherry-pick release-7.11

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@mattermost-build mattermost-build mentioned this pull request Jun 22, 2023
Merged
mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Jun 22, 2023
@mgdelacroix @mattermost-build
Updates import to read with a scanner (mattermost#4788)
f7e2084 
* Updates import to read with a scanner

* Fix linter

(cherry picked from commit 625526c)
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Jun 22, 2023
mgdelacroix added a commit that referenced this pull request Jun 22, 2023
@mattermost-build @mgdelacroix
Updates import to read with a scanner (#4788) (#4789)
be9f99b 
* Updates import to read with a scanner

* Fix linter

(cherry picked from commit 625526c)

Co-authored-by: Miguel de la Cruz <miguel@mcrx.me>
mgdelacroix added a commit that referenced this pull request Jul 28, 2023
@mgdelacroix
Updates import to read with a scanner (#4788)
ad75c5c 
* Updates import to read with a scanner

* Fix linter
@mgdelacroix mgdelacroix mentioned this pull request Jul 28, 2023
Merged
mgdelacroix added a commit that referenced this pull request Jul 28, 2023
@mgdelacroix
Updates import to read with a scanner (#4788)
45473f2 
* Updates import to read with a scanner

* Fix linter
@mgdelacroix mgdelacroix mentioned this pull request Jul 28, 2023
Merged
mgdelacroix added a commit that referenced this pull request Jul 28, 2023
@mgdelacroix
Updates import to read with a scanner (#4788)
11df637 
* Updates import to read with a scanner

* Fix linter
mgdelacroix added a commit that referenced this pull request Jul 28, 2023
@mgdelacroix
Updates import to read with a scanner (#4788)
cfa38b8 
* Updates import to read with a scanner

* Fix linter
mgdelacroix added a commit that referenced this pull request Jul 28, 2023
@mgdelacroix
Cherry pick enhance validation 7.10 (#4822)
b74c55a 
* Updates import to read with a scanner (#4788)

* Updates import to read with a scanner

* Fix linter

* Unify and enhance block validation (#4790)

* Adds limit check for block titles

* Adds limit check for the aggregation of the fields

* Fix linter

* Adds tests

* Fix err check method order
mgdelacroix added a commit that referenced this pull request Jul 28, 2023
@mgdelacroix
Cherry pick enhance validation 7.8 (#4821)
9ec1e42 
* Unify and enhance block validation (#4790)

* Adds limit check for block titles

* Adds limit check for the aggregation of the fields

* Fix linter

* Adds tests

* Fix err check method order

* Updates import to read with a scanner (#4788)

* Updates import to read with a scanner

* Fix linter

* Fix migration test
sbishel pushed a commit that referenced this pull request Aug 8, 2023
@mgdelacroix @sbishel
Updates import to read with a scanner (#4788)
2f13716 
* Updates import to read with a scanner

* Fix linter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbishel sbishel sbishel approved these changes

@esarafianou esarafianou esarafianou approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Milestone
v7.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mgdelacroix @mattermost-build @sbishel @esarafianou