Adding backward compatibility for 5.38 #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
requested review from
wiggin77 and
chenilim
and removed request for
a team
chenilim
previously requested changes
Aug 10, 2021
| } else { | ||
| this.channelHeaderButtonId = registry.registerChannelHeaderButtonAction(<FocalboardIcon/>, () => { | ||
| const currentChannel = store.getState().entities.channels.currentChannelId | ||
| window.open(`${window.location.origin}/plug/focalboard/workspace/${currentChannel}`) |
There was a problem hiding this comment.
I believe this should be /plugins/focalboard/...
There was a problem hiding this comment.
The problem was with other thing, see the commit that I included.
mgdelacroix
approved these changes
Aug 11, 2021
jespino
dismissed
chenilim’s stale review
Addressed the changes and reviewed by Miguel
jespino
added a commit
that referenced
this pull request
Aug 11, 2021
* Adding backward compatibility for 5.38 * Fixing problem with urls
This was referenced Aug 11, 2021
mgdelacroix
added
the
CherryPick/Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.