Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a weird import bug on react-day-picker #933

Merged
merged 2 commits into from Aug 11, 2021
Merged

Fixing a weird import bug on react-day-picker #933

merged 2 commits into from Aug 11, 2021

Conversation

jespino
Copy link
Member

@jespino jespino commented Aug 11, 2021 •
edited

Fixes #918

@jespino jespino requested a review from a team as a code owner August 11, 2021 16:47
@jespino jespino requested review from wiggin77 and sbishel and removed request for a team August 11, 2021 16:47
wiggin77
wiggin77 approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust this alias resolves the build error. What I don't understand is how the build error got past CI and deployed??

@chenilim chenilim added this to the v0.9 milestone Aug 11, 2021
sbishel
sbishel approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, builds without warning, works as plugin

@sbishel sbishel merged commit 2287931 into mattermost:main Aug 11, 2021
@sbishel
Copy link
Member

sbishel commented Aug 11, 2021

/cherry-pick release-0.9.0

@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@mattermod
Copy link
Contributor

Error trying doing the automated Cherry picking. Please do this manually

fatal: No such remote 'upstream'

+++ Returning you to the main branch and cleaning up.

sbishel pushed a commit to sbishel/focalboard that referenced this pull request Aug 11, 2021
@jespino @sbishel
Fixing a weird import bug on react-day-picker (mattermost#933)
86285d2 
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
(cherry picked from commit 2287931)
sbishel added a commit that referenced this pull request Aug 11, 2021
@sbishel @jespino
Fixing a weird import bug on react-day-picker (#933) (#935)
34ba964 
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
(cherry picked from commit 2287931)

Co-authored-by: Jesús Espino <jespinog@gmail.com>
@sbishel sbishel added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Aug 11, 2021
@ogi-m
Copy link
Contributor

ogi-m commented Aug 13, 2021

Tested and passed on RC4 - date picker opens as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@sbishel sbishel sbishel approved these changes

Assignees
No one assigned
Labels
CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

Bug: Error when selecting a date property in card view
6 participants
@jespino @sbishel @mattermod @ogi-m @wiggin77 @chenilim