Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving logo and title to the global header #947

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Conversation

jespino
Copy link
Member

@jespino jespino commented Aug 12, 2021

Fixes #942

@jespino jespino requested a review from a team as a code owner August 12, 2021 07:15
@jespino jespino requested review from harshilsharma63 and chenilim and removed request for a team August 12, 2021 07:15
@jespino jespino added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Aug 12, 2021
Copy link
Member

@harshilsharma63 harshilsharma63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jespino jespino merged commit aaa0b0d into mattermost:main Aug 12, 2021
jespino added a commit that referenced this pull request Aug 12, 2021
* Moving logo and title to the global header

* Fixing problems with the new header

* Fixing lint problems
@jespino jespino added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone 3: Reviews Complete All reviewers have approved the pull request and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boards title should appear in Global Nav, not sidebar when running as a plugin
2 participants