This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
Latest urls #27
Merged
Latest urls #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to introduce a waiting step |
|
Crap - there is no config available in the tests on CircleCI |
|
Updated with a set of 3 unit tests to ensure routing rules are added as expected |
metanerd
reviewed
Apr 17, 2020
metanerd
reviewed
Apr 17, 2020
metanerd
reviewed
Apr 17, 2020
metanerd
reviewed
Apr 17, 2020
metanerd
reviewed
Apr 17, 2020
metanerd
reviewed
Apr 17, 2020
metanerd
reviewed
Apr 17, 2020
metanerd
reviewed
Apr 17, 2020
|
My review seems like a lot, but it is really just nitpicking. Otherwise it looks really good! 🎉 |
Co-Authored-By: Elisabeth Kulzer <elikul@elikul.de>
Co-Authored-By: Elisabeth Kulzer <elikul@elikul.de>
Co-Authored-By: Elisabeth Kulzer <elikul@elikul.de>
Co-Authored-By: Elisabeth Kulzer <elikul@elikul.de>
Co-Authored-By: Elisabeth Kulzer <elikul@elikul.de>
All good - thank you for the feedback - I believe the config changes in the private repo need to be merged first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Head to open a new PR