introduce provisioner.PrepareCluster step #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks out the part of the provisioner that needs to modify the cluster (to record changes to the ProvisionerMetadata) from the part that actually provisions, making it explicit in the supervisor that we need to write said changes back to disk. I had incorrectly removed the "save-after-provision" step when an error occurs during the provisioning. Hopefully this will make it more obvious.
gabrieljackson
approved these changes
May 17, 2019
gabrieljackson
approved these changes
May 17, 2019
jwilander
approved these changes
May 22, 2019
jwilander
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks out the part of the provisioner that needs to modify the
cluster (to record changes to the ProvisionerMetadata) from the part
that actually provisions, making it explicit in the supervisor that we
need to write said changes back to disk.
I had incorrectly removed the "save-after-provision" step when an error
occurs during the provisioning. Hopefully this will make it more
obvious.