Upgrade kops to 1.22 #708
Upgrade kops to 1.22 #708
Conversation
stafot
requested review from
gabrieljackson,
stylianosrigas,
Szymongib and
angeloskyratzakos
mm-cloud-bot
added
kind/chore
| k8sClient, err := k8s.NewFromFile(kops.GetKubeConfigPath(), logger) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| _, err = k8sClient.UpdateStorageClassVolumeBindingMode("gp2") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| logger.WithField("name", kopsMetadata.Name).Info("Successfully updated storage class") |
There was a problem hiding this comment.
This block fails at the moment and in my understanding of things is totally obsolete and can be safely removed. But if your understanding is different @gabrieljackson and @Szymongib feel free to correct me.
There was a problem hiding this comment.
Hmm, I can't remember what this was used for, but would agree that if there are no perceived issues then it should be okay to remove. The code was added by @stylianosrigas so let's check with him as well.
stafot
force-pushed
the
chore/CLD-1543
branch
4 times, most recently
from
d72f5d3
to
44812b9
Compare
| @@ -79,11 +79,11 @@ func (c *Cmd) CreateCluster(name, cloud string, kopsRequest *model.KopsMetadataR | |||
| // Example setValue: spec.kubernetesVersion=1.10.0 | |||
| func (c *Cmd) SetCluster(name, setValue string) error { | |||
There was a problem hiding this comment.
There is another SetInstanceGroup method that should need this change: https://github.com/mattermost/mattermost-cloud/blob/master/internal/tools/kops/instance_groups.go#L221
| k8sClient, err := k8s.NewFromFile(kops.GetKubeConfigPath(), logger) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| _, err = k8sClient.UpdateStorageClassVolumeBindingMode("gp2") | ||
| if err != nil { | ||
| return err | ||
| } | ||
| logger.WithField("name", kopsMetadata.Name).Info("Successfully updated storage class") |
There was a problem hiding this comment.
Hmm, I can't remember what this was used for, but would agree that if there are no perceived issues then it should be okay to remove. The code was added by @stylianosrigas so let's check with him as well.
Issue: CLD-1543 Signed-off-by: Stavros Foteinopoulos <stafot@gmail.com>
Issue: Signed-off-by: Stavros Foteinopoulos <stafot@gmail.com>
Issue: Signed-off-by: Stavros Foteinopoulos <stafot@gmail.com>
Issue:
This reverts commit 83000f7.
Issue: CLD-1543
Summary
Upgrade kops to 1.22
Ticket Link
https://mattermost.atlassian.net/browse/CLD-1543
Release Note