Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refinement of flag parsing #780

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Refinement of flag parsing #780

merged 2 commits into from
Dec 13, 2022

Conversation

mirshahriar
Copy link
Contributor

Summary

Completed parsing refinement of following flags.

$ cloud cluster installation
$ cloud cluster annotation

Ticket Link

Ticket: MM-48846

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 7, 2022
@mirshahriar mirshahriar self-assigned this Dec 7, 2022
@mirshahriar mirshahriar added the 2: Dev Review Requires review by a developer label Dec 8, 2022
Copy link
Contributor

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work with this refactors 👍 💪

Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mirshahriar mirshahriar merged commit d66b2ce into master Dec 13, 2022
@mirshahriar mirshahriar deleted the MM-48846 branch December 13, 2022 16:57
@mirshahriar mirshahriar added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
4 participants