Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-49378] Added Nginx SLO for Enterprise customer #823

Merged
merged 7 commits into from
Jan 10, 2023
Merged

[MM-49378] Added Nginx SLO for Enterprise customer #823

merged 7 commits into from
Jan 10, 2023

Conversation

mirshahriar
Copy link
Contributor

@mirshahriar mirshahriar commented Jan 5, 2023 •
edited
Loading

Summary

We need to provide list of enterprise group while running provisioner.

$ cloud server [flags]

Flags:
      --enterprise-groups strings.       The list of enterprise group ids to create dedicated Nginx SLOs for.

Sample SLO

objective: 99.9
sli:
  events:
    errorQuery: sum(rate(nginx_ingress_controller_request_duration_seconds_count{exported_service='mm-d5wh',status=~'(5..|429|499)'}[{{.window}}]))
    totalQuery: sum(rate(nginx_ingress_controller_request_duration_seconds_count{exported_service='mm-d5wh'}[{{.window}}]))

Ticket Link

Fixes MM-49378

Release Note

Added Nginx SLO for enterprise customer

@mm-cloud-bot mm-cloud-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 5, 2023
@mirshahriar mirshahriar self-assigned this Jan 5, 2023
@mirshahriar mirshahriar added the 2: Dev Review Requires review by a developer label Jan 5, 2023
fmartingr
fmartingr approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

internal/provisioner/nginx_sli.go Outdated Show resolved Hide resolved
gabrieljackson
gabrieljackson reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small request.

cmd/cloud/server_flag.go Outdated Show resolved Hide resolved
@stafot
Copy link
Contributor

stafot commented Jan 5, 2023

Please change default objective to 99.5

gabrieljackson
gabrieljackson approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mirshahriar mirshahriar added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Jan 10, 2023
@mirshahriar mirshahriar merged commit 03ab5fe into master Jan 10, 2023
@mirshahriar mirshahriar deleted the MM-49378 branch January 10, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmartingr fmartingr fmartingr approved these changes

@gabrieljackson gabrieljackson gabrieljackson approved these changes

@stafot stafot Awaiting requested review from stafot

Assignees

@mirshahriar mirshahriar

Labels
4: Reviews Complete All reviewers have approved the pull request release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
No milestone
5 participants
@mirshahriar @stafot @fmartingr @gabrieljackson @mm-cloud-bot