[MM-49396] Add Name tag in ELB resources #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-cloud-bot
added
the
release-note-none
fmartingr
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
LGTM. Only minor naming issues. Seems an elegant way to solve the problem of AWS providing two different packages so we can still operate over classic load balancers. But that poses a question. Should we migrate classic load balancers? If AWS is stopping providing support this could be a worse problem in the future if the APIs get deprecated. IIRC for now is safe to have CLBs on a VPC, but who knows what could happen. cc: @gabrieljackson @stylianosrigas
Co-authored-by: Felipe Martin <812088+fmartingr@users.noreply.github.com>
stafot
approved these changes
Jan 9, 2023
gabrieljackson
approved these changes
Jan 10, 2023
# Conflicts: # go.mod # go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding Name tag in ELB resources
Ticket Link
Resolves MM-49396
Release Note