-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Perseus database type #827
Conversation
8cc1c4a
to
5d456cd
Compare
This change includes the basic functionality needed to deploy the Perseus database proxy service and to use it for new installations.
5d456cd
to
bc39989
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following logic was a bit tricky at first but this looks good to me, my only worries are with naming (commented out below) on parts that I did not fully understand or found confusing. Some tests for the critical methods would also be nice.
Although this PR refactors some of the shared code with PGBouncer, there is a lot more we can do. Out of a desire to not break anything some code was duplicated for now with some minor tweaks which can be improved later.
Can you put comments on the ones you already duplicated so we can easily track those?
This change includes the basic functionality needed to deploy the Perseus database proxy service and to use it for new installations.
High Level Perseus Architecture:
![Screenshot 2023-01-09 at 10 53 28 PM](https://user-images.githubusercontent.com/3694686/211458201-93e1cbca-5bae-4894-9789-84929e6a8fa7.png)
Reviewer Notes: