Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-12340] update release process #182

Merged
merged 2 commits into from Nov 5, 2018
Merged

[MM-12340] update release process #182

merged 2 commits into from Nov 5, 2018

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Nov 5, 2018

No description provided.

Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple grammar/wording suggestions

site/content/internal/release-process.md Outdated Show resolved Hide resolved
site/content/internal/release-process.md Outdated Show resolved Hide resolved
@jasonblais jasonblais requested review from amyblais and removed request for jasonblais November 5, 2018 13:50
@jasonblais jasonblais added 1: PM Review Requires review by a product manager 2: Editor Review Requires review by an editor labels Nov 5, 2018
@jasonblais
Copy link
Contributor

jasonblais commented Nov 5, 2018

Overall looks good. Requesting @amyblais to help review too, as she's the best from PM side on this PR (for editor review and given she's the release manager).

@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor 1: PM Review Requires review by a product manager labels Nov 5, 2018
@cpanato cpanato merged commit b68db45 into master Nov 5, 2018
@cpanato cpanato deleted the MM-12340 branch November 5, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants