Add blog authors and other minor updates #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jwilander
commented
Jan 31, 2019
jwilander
commented
- Added the blog authors with links to community.mattermost.com and GitHub to bottom of blog posts
- Added blog authors on blog list page
- Removed blog tags and added more categories
jwilander
added
1: PM Review
lieut-data
approved these changes
Jan 31, 2019
|
The categories take me to a 404 error page, e.g. https://developers.mattermost.com/blog/npm-v6/categories/announcement Otherwise, great improvements here 👍 |
jasonblais
requested changes
Jan 31, 2019
|
Hmm looks like the categories were broken already, looking into it |
|
Odd they work fine locally for me |
|
@jasonblais I couldn't figure out why the categories weren't working so in the interim I just replaced them in the sidebar with links to other blog posts |
lieut-data
approved these changes
Jan 31, 2019
| @@ -1,6 +1,12 @@ | |||
| --- | |||
| title: "Submitting Great PRs" | |||
| slug: submitting-great-prs | |||
There was a problem hiding this comment.
I'm not terribly worried, but I note that this will break any inbound links to this page. Is it easy to add a second slug? 0/5.
There was a problem hiding this comment.
Will add an alias for it
|
Chatted with Jason about the sidebar, it's not perfect but we're ok with it for now |
hanzei
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.